Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Filters Cache restore logic #6908

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner December 25, 2023 10:06
Copy link

netlify bot commented Dec 25, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9aa34a4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/658959f065a39200085865e0
😎 Deploy Preview https://deploy-preview-6908--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Dec 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2023 10:32am

@nihal467
Copy link
Member

LGTM

Copy link

cypress bot commented Dec 25, 2023

Passing run #1756 ↗︎

0 91 0 0 Flakiness 0

Details:

Fixes Filters Cache restore logic
Project: CARE Commit: 9aa34a408e
Status: Passed Duration: 02:22 💡
Started: Dec 25, 2023 10:34 AM Ended: Dec 25, 2023 10:37 AM

Review all test suite changes for PR #6908 ↗︎

@khavinshankar khavinshankar merged commit 97ca611 into develop Dec 25, 2023
28 checks passed
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@rithviknishad rithviknishad deleted the fix-filters-cache-restore-logic branch February 19, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Back button in CNS is not Working
3 participants