Doctor #6913
Doctor #6913
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for care-egov-staging failed.
|
❌ Deploy Preview for care-net failed.
|
| @@ -61,7 +61,7 @@ const TextFormField = forwardRef((props: TextFormFieldProps, ref) => { | |||
| required={field.required} | |||
| onFocus={props.onFocus} | |||
| onBlur={props.onBlur} | |||
| onChange={(e) => field.handleChange(e.target.value)} | |||
| onChange={props.onChange} | |||
There was a problem hiding this comment.
Why was this changed?
This would break all of the other existing usages of the text form field in the platform.
There was a problem hiding this comment.
Revert the package lock changes too
There was a problem hiding this comment.
@shramanpaul you can ignore the keyboard shortcut feature as it's already covered correctly in #6915
|
It'd also be nice to change the PR title to be something more appropriate to the changes you've made. |
|
Ok @rithviknishad then i will be making a new PR with the proposed changes and will be linking this pr along with it. |
|
👋 Hi, @shramanpaul, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
Closing as alt. #6932 |
Proposed Changes
Fixes Patient Notes UX improvement #6824
Change 1 : submit by pressing enter on the keyboard
Change 2 : have a draft feature for the messages that were typed and not posted (this should also fix the issue of typed message going away when going full screen or vice versa)
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
carefe.mp4
please have a review @rithviknishad