Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Bed Capacity Cards #6925

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Redesign Bed Capacity Cards #6925

merged 6 commits into from
Jan 4, 2024

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Dec 26, 2023

Fixes #6620
This pull request includes a redesign of the bed capacity cards in the FacilityBedCapacity component. The changes include adding a reverse-spin animation and adjusting the layout of the cards.

Referenced Figma Design

image

Design in the PR

image
image
image
image
image

@Ashesh3 Ashesh3 requested a review from a team as a code owner December 26, 2023 20:06
Copy link

vercel bot commented Dec 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 3:36pm

Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f7e878a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65942d440a6f8800084fa4ec
😎 Deploy Preview https://deploy-preview-6925--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Dec 26, 2023

1 failed test on run #1812 ↗︎

1 94 0 0 Flakiness 0

Details:

Redesign Bed Capacity Cards
Project: CARE Commit: f7e878a393
Status: Failed Duration: 02:38 💡
Started: Jan 2, 2024 3:39 PM Ended: Jan 2, 2024 3:41 PM
Failed  cypress/e2e/patient_spec/patient_crud.cy.ts • 1 failed test

View Output

Test Artifacts
Patient Creation with consultation > Patient Detail verification post registration Test Replay Screenshots

Review all test suite changes for PR #6925 ↗︎

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also change this to use useQuery while we have anyways refactored the BedTypeCard component?

@Ashesh3
Copy link
Member Author

Ashesh3 commented Dec 27, 2023

Could we also change this to use useQuery while we have anyways refactored the BedTypeCard component?

Yep, that'll be good. I've made the changes.

@nihal467
Copy link
Member

@Ashesh3 we should be thinking about a replacement for the refresh button

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 28, 2023
Copy link

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

nihal467 commented Jan 2, 2024

image

@Ashesh3 i believe we discussed replacing the icon with the percentage of bed usage or something more value adding

@nihal467
Copy link
Member

nihal467 commented Jan 2, 2024

LGTM

@nihal467
Copy link
Member

nihal467 commented Jan 2, 2024

image

new Ui updated view, LGTM approved

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of request, useQuery has support for managing loading states and auto refetching, but this is fine for now since we have migrated away from redux in this PR and it works.

cc: @Ashesh3

@khavinshankar khavinshankar merged commit d366f64 into develop Jan 4, 2024
34 of 38 checks passed
@khavinshankar khavinshankar deleted the bed-cap-design branch January 4, 2024 09:30
Copy link

github-actions bot commented Jan 4, 2024

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design Enhancement Scope in Facility Bed Capacity Section
4 participants