Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latitude and longitude handling in FacilityCreate component #6934

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Dec 28, 2023

This pull request fixes an issue in the FacilityCreate component where the latitude and longitude values were not being handled correctly. The issue was resolved by checking if the latitude and longitude values exist before converting them to strings.

@Ashesh3 Ashesh3 requested a review from a team as a code owner December 28, 2023 08:14
Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2023 8:36am

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 28eeb69
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/658d3375a5a9c40008ca9458
😎 Deploy Preview https://deploy-preview-6934--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Dec 28, 2023

Passing run #1788 ↗︎

0 94 0 0 Flakiness 0

Details:

Fix latitude and longitude handling in FacilityCreate component
Project: CARE Commit: 3ba8c82206
Status: Passed Duration: 02:40 💡
Started: Dec 28, 2023 8:21 AM Ended: Dec 28, 2023 8:24 AM

Review all test suite changes for PR #6934 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 36fa6e3 into develop Dec 28, 2023
19 of 26 checks passed
@khavinshankar khavinshankar deleted the fix-facility-loca branch December 28, 2023 08:36
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants