Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance UI of Shifting Board #6956

Merged
merged 18 commits into from
Jan 23, 2024
Merged

Conversation

Arzzam
Copy link
Contributor

@Arzzam Arzzam commented Jan 1, 2024

Proposed Changes

Shifting.Board.enhance.mov

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Arzzam Arzzam requested a review from a team as a code owner January 1, 2024 09:15
Copy link

vercel bot commented Jan 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 4:05pm

Copy link

netlify bot commented Jan 1, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9ace4d4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65ae920982085f00083b73e3
😎 Deploy Preview https://deploy-preview-6956--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Arzzam Arzzam changed the title Enhance UI Enhance UI of Shifting Board Jan 1, 2024
@Pranshu1902
Copy link
Contributor

Pranshu1902 commented Jan 1, 2024

@Arzzam there is still a scroll bar on the right side of the page (shown in blue in the image below)
Screenshot from 2024-01-01 15-45-56

And could you add a transparent circular effect on hover around the arrow? Kind of like the export button on the same page
image
Reference:
image

cc @rithviknishad

@Arzzam
Copy link
Contributor Author

Arzzam commented Jan 1, 2024

Yeah sure, I will add some circular effect for the buttons.
How can I fix the scroll bar. Can I proceed with a App router change?

Is these buttons are ok in hover state?
image

@Pranshu1902
Copy link
Contributor

Pranshu1902 commented Jan 1, 2024

@rithviknishad could you confirm the method to remove the extra scroll bar on the extreme right of the page

@nihal467
Copy link
Member

@Arzzam

image

  • Keep the left and right arrow outside the board, where I marked the red circle
  • If we are in the leftmost and there is no more left to go with the arrow, keep the left arrow hidden similarly to the rightmost as well

@Arzzam
Copy link
Contributor Author

Arzzam commented Jan 10, 2024

@nihal467
#6636 (comment)

As I discussed with @Pranshu1902 in issue, It was the one he came up with
so I done just like he said

@nihal467
Copy link
Member

@Arzzam The current UI is overlapping with the shifting board data, and it doesn't look good. Please modify it based on the comment i made above

@Arzzam
Copy link
Contributor Author

Arzzam commented Jan 21, 2024

Updated as requested @Pranshu1902 @nihal467 @rithviknishad

src/Components/Shifting/BoardView.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 added the reviewed reviewed by a core member label Jan 22, 2024
@khavinshankar khavinshankar merged commit 20cac43 into ohcnetwork:develop Jan 23, 2024
35 of 36 checks passed
Copy link

@Arzzam We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design Enhancement Scope in Shifting Board
6 participants