Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more symptoms and move OTHERS to bottom #6958

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

Omkar76
Copy link
Contributor

@Omkar76 Omkar76 commented Jan 1, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

image

@Omkar76 Omkar76 requested a review from a team as a code owner January 1, 2024 15:37
Copy link

vercel bot commented Jan 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 3:25pm

Copy link

netlify bot commented Jan 1, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6e85b91
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65ae88a6f4738d0007688c86
😎 Deploy Preview https://deploy-preview-6958--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider making this as an AutocompleteFormField instead of SelectFormField now that there's lot more options?

@Omkar76
Copy link
Contributor Author

Omkar76 commented Jan 2, 2024

Updated to use AutoCompleteMultiSelectFormField.

Will send another PR to accept optionDescription prop in this component as discussed with Rithvik on slack.

image

@rithviknishad rithviknishad removed the question Further information is requested label Jan 8, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit b9544b5 into coronasafe:develop Jan 23, 2024
36 checks passed
Copy link

@Omkar76 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symptoms : Expand list
5 participants