Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes responsiveness in Facilty Home #6960

Merged
merged 20 commits into from
Feb 7, 2024
Merged

Fixes responsiveness in Facilty Home #6960

merged 20 commits into from
Feb 7, 2024

Conversation

konavivekramakrishna
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel Vercel
Copy link

vercel bot commented Jan 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 10:01am

@netlify Netlify
Copy link

netlify bot commented Jan 1, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 684797f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65c354e557181f0008079685
😎 Deploy Preview https://deploy-preview-6960--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@konavivekramakrishna
Copy link
Contributor Author

konavivekramakrishna commented Jan 1, 2024 •
edited
Loading

image

Collapsing the sidebar to prevent overlapping with buttons caused by long addresses.

@konavivekramakrishna konavivekramakrishna marked this pull request as ready for review January 1, 2024 22:12
@konavivekramakrishna konavivekramakrishna requested a review from a team as a code owner January 1, 2024 22:12
@nihal467
Copy link
Member

@konavivekramakrishna

  • Don't keep the sidebar by default collapsed for the facility detail page in the normal view

image

  • if there any overflow or overlapping, just take it to next line

@konavivekramakrishna
Copy link
Contributor Author

https://www.loom.com/share/af7217bb652e4d7696ca417d78deec5d?sid=c399a179-7f41-42ec-9834-489d588c492d

@nihal467 can you please check once

@konavivekramakrishna konavivekramakrishna restored the fix#6621 branch January 30, 2024 01:37
@nihal467
Copy link
Member

nihal467 commented Feb 2, 2024

LGTM

@khavinshankar
Copy link
Member

@rithviknishad @Ashesh3 please review this pr

rithviknishad
rithviknishad approved these changes Feb 7, 2024
View reviewed changes
src/Components/Facility/FacilityHome.tsx Outdated Show resolved Hide resolved
@rithviknishad rithviknishad added reviewed reviewed by a core member and removed needs review labels Feb 7, 2024
@khavinshankar khavinshankar merged commit d4ac204 into coronasafe:develop Feb 7, 2024
35 of 36 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

@konavivekramakrishna We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
reviewed reviewed by a core member tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the facility detail page more properly responsive
5 participants
@konavivekramakrishna @nihal467 @khavinshankar @Ashesh3 @rithviknishad