Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Abha linking process #7000

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Improve Abha linking process #7000

merged 4 commits into from
Jan 17, 2024

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Jan 10, 2024

Resolves #6999

Todo:

  • Have a draft for the Abha linking process, the user should be able to continue from where they left off before (will be handled in a new pr)
  • Already have an Abha number should be there till the end of registration
  • Add support to use Abha address for linking (check if this is directly possible)

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit cc18ebe
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65a782142c1c0a0008d6bbed
😎 Deploy Preview https://deploy-preview-7000--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 7:31am

@khavinshankar khavinshankar changed the title Improve Abha linking process (DRAFT) Improve Abha linking process Jan 10, 2024
Copy link

cypress bot commented Jan 10, 2024

Passing run #1894 ↗︎

0 98 0 0 Flakiness 0

Details:

Improve Abha linking process
Project: CARE Commit: cc18ebe352
Status: Passed Duration: 02:18 💡
Started: Jan 17, 2024 7:34 AM Ended: Jan 17, 2024 7:36 AM

Review all test suite changes for PR #7000 ↗︎

@khavinshankar khavinshankar requested a review from a team as a code owner January 16, 2024 07:15
@khavinshankar khavinshankar changed the title (DRAFT) Improve Abha linking process Improve Abha linking process Jan 16, 2024
@khavinshankar khavinshankar added needs testing P1 breaking issue or vital feature ABDM labels Jan 16, 2024
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Components/ABDM/LinkABHANumberModal.tsx Show resolved Hide resolved
@rithviknishad rithviknishad added reviewed reviewed by a core member and removed needs review labels Jan 16, 2024
@nihal467
Copy link
Member

@khavinshankar
image

@khavinshankar
Copy link
Member Author

@khavinshankar image

@nihal467 this is an existing issue, will create a new issue to handle this (it is a backend issue). It is caused because of trying to link the same Abha number multiple times

@nihal467
Copy link
Member

LGTM

1 similar comment
@nihal467
Copy link
Member

LGTM

@gigincg gigincg merged commit df758d2 into develop Jan 17, 2024
59 of 61 checks passed
Copy link

@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@gigincg gigincg deleted the improve_abha_linking branch January 17, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ABDM P1 breaking issue or vital feature reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ABHA linking on patients
5 participants