Fix inconsistent removal of facility filters

[Omkar76]

Proposed Changes

• Fixes Inconsistent Auto-Removal of facility advance Filter When Closing Parent Filter #7013
• When state is removed also remove district and local_body filters
• When district is removed also remove local_body filter

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

facility-filter.webm

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 22, 2024 5:49pm

[netlify]

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	9772884
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/65aeaa73f15b9f0008459d38
😎 Deploy Preview	https://deploy-preview-7031--care-egov-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nihal467]

@Omkar76 the facility page filter cache functionality is not working.

Steps to reproduce:

1. Apply facility advance filters and visit patient using the side bar
2. come back to facility page and the applied filters are missing

[Omkar76]

Debugged it. So qParams is empty when we go back to /facility/. The useFilters() hook will update url by reading localStorage. but by this time useEffect() in HospitalList has already batched remove operation for district and local_body params bacause it found !qParams.state to be true on very first render cycle.

Solved this by checking if qParams is empty - in this case we don't remove any params.
Video is updated in PR.

[rithviknishad]

I still find if (Object.keys(qParams).length === 0) return; line hard to understand why it's there. Maybe would the following be a more readable and correct approach of what you are trying to do?

cc: @Ashesh3

Suggested change

	if (Object.keys(qParams).length === 0) return;
	if (!qParams.state) {
	advancedFilter.removeFilters(["district", "local_body"]);
	}
	if (!qParams.district) {
	advancedFilter.removeFilters(["local_body"]);
	}
	}, [advancedFilter, qParams]);
	if (!qParams.state && (qParams.district || qParams.local_body)) {
	advancedFilter.removeFilters(["district", "local_body"]);
	}
	if (!qParams.district && qParams.local_body) {
	advancedFilter.removeFilters(["local_body"]);
	}
	}, [advancedFilter, qParams]);

[Ashesh3]

The suggestion seems good and reads better.

• If state is not present, but district or local_body is, then remove both
• If district is not preset but we still have local_body, then remove it.

[nihal467]

LGTM

[github-actions]

@Omkar76 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.