Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Asset Type" (Assets to be always "Internal") #7061

Closed

Conversation

shyamprakash123
Copy link
Contributor

Proposed Changes

  • Fixes Hide "Asset Type" (Assets to be always "Internal") #6789

  • Remove "Asset Type" select input from asset create/edit form.

  • Upon creating an asset, it should always create with asset type as "Internal"

  • Remove it from the asset details page too.

  • Remove Asset Type filter from Advanced Filters

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shyamprakash123 shyamprakash123 requested a review from a team as a code owner January 19, 2024 05:38
Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2024 0:02am

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 88b5444
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65bf7c8a6e4813000867b3da
😎 Deploy Preview https://deploy-preview-7061--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

👋 Hi, @shyamprakash123,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added merge conflict pull requests with merge conflict and removed merge conflict pull requests with merge conflict labels Jan 23, 2024
Copy link

👋 Hi, @shyamprakash123,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Copy link

👋 Hi, @shyamprakash123,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 31, 2024
@nihal467
Copy link
Member

nihal467 commented Feb 6, 2024

@shyamprakash123 you might have mishandled the merge conflicts and the file changes are not related to the PR. I would suggest taking advice on how to handle merge conflicts and for now, close this PR and create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict pull requests with merge conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide "Asset Type" (Assets to be always "Internal")
2 participants