Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support to remove all filters via useFilters's utility method and fixes issues with patient advanced filters #7096

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Adds support to remove all filters via useFilters's utility method and fixes issues with patient advanced filters #7096

merged 3 commits into from
Jan 24, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 24, 2024 •
edited
Loading

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner January 24, 2024 12:57
@netlify Netlify
Copy link

netlify bot commented Jan 24, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3e1c8b9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65b125728e15ce0008965d4e
😎 Deploy Preview https://deploy-preview-7096--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel Vercel
Copy link

vercel bot commented Jan 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 2:58pm

@cypress Cypress
Copy link

cypress bot commented Jan 24, 2024 •
edited
Loading

Passing run #1959 ↗︎

0 104 0 0 Flakiness 0

Details:

Adds support to remove all filters via `useFilters`'s utility method and fixes i...
Project: CARE Commit: 3e1c8b913a
Status: Passed Duration: 02:43 💡
Started: Jan 24, 2024 3:01 PM Ended: Jan 24, 2024 3:04 PM

Review all test suite changes for PR #7096 ↗︎

Ashesh3
Ashesh3 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change!

@Ashesh3 Ashesh3 added reviewed reviewed by a core member and removed needs review labels Jan 24, 2024
@nihal467
Copy link
Member

@rithviknishad
image

when i apply only the bed type filter, the clear all filter badge is missing

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit b165049 into develop Jan 24, 2024
62 checks passed
@github-actions GitHub Actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the rithviknishad/improve-remove-all-filters branch January 24, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
reviewed reviewed by a core member tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patient advance filters clear button is malfunctioning
4 participants
@rithviknishad @nihal467 @Ashesh3 @khavinshankar