Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera feed not working on asset configure page for IOS devices #7098

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jan 24, 2024

This pull request fixes the issue where the camera feed was not working on the asset configure page for IOS devices. The issue was caused by an incorrect URL being used for the video stream. This PR updates the URL to the correct format for IOS devices, allowing the camera feed to work properly.

@Ashesh3 Ashesh3 requested a review from a team as a code owner January 24, 2024 16:55
Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 5:01pm

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9582cb7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65b1422ab66fe30008c77079
😎 Deploy Preview https://deploy-preview-7098--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jan 24, 2024

Passing run #1962 ↗︎

0 104 0 0 Flakiness 0

Details:

Fix camera feed not working on asset configure page for IOS devices
Project: CARE Commit: 9582cb7c2c
Status: Passed Duration: 02:33 💡
Started: Jan 24, 2024 5:04 PM Ended: Jan 24, 2024 5:07 PM

Review all test suite changes for PR #7098 ↗︎

@nihal467
Copy link
Member

LGTM

@rithviknishad rithviknishad added reviewed reviewed by a core member and removed needs review labels Jan 24, 2024
@khavinshankar khavinshankar merged commit a45f80b into develop Jan 25, 2024
60 of 62 checks passed
@khavinshankar khavinshankar deleted the fix-asset-configure-feed-ios branch January 25, 2024 02:10
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants