Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace font-awesome icons by CareIcon component #7118

Merged
merged 14 commits into from
Feb 21, 2024

Conversation

Omkar76
Copy link
Contributor

@Omkar76 Omkar76 commented Jan 29, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Omkar76 Omkar76 requested a review from a team as a code owner January 29, 2024 18:13
Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d84a969
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65d5ad122eddf4000889be9e
😎 Deploy Preview https://deploy-preview-7118--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 7:58am

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do uninstall fontawesome related packages and remove related configurations

@Omkar76
Copy link
Contributor Author

Omkar76 commented Jan 30, 2024

@rithviknishad found some more icons by searching fa-. these were not matched by that regex earlier. I've replaced those in this commit. Also npm uninstalled fontawesome and removed from index.css

@rithviknishad
Copy link
Member

@rithviknishad found some more icons by searching fa-. these were not matched by that regex earlier. I've replaced those in this commit. Also npm uninstalled fontawesome and removed from index.css

Awesome 🚀

Copy link

👋 Hi, @Omkar76,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 31, 2024
@nihal467
Copy link
Member

nihal467 commented Feb 4, 2024

@Omkar76 can you clear the merge conflict

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Omkar76 we generally apply text-2xl to all CareIcon's classname. But in the migrated one's that classname is not present

Copy link

👋 Hi, @Omkar76,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

@Omkar76 can you clear the merge conflict

@khavinshankar khavinshankar merged commit 925eb6b into coronasafe:develop Feb 21, 2024
24 of 27 checks passed
Copy link

@Omkar76 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@Omkar76 Omkar76 deleted the fa-2-care-icons branch February 22, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration of font-awesome icons to CareIcon
5 participants