Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce (i) Button Popover Component in HL7Monitor and VentilatorPatientVitalsMonitor #7228

Merged
merged 18 commits into from Feb 28, 2024
Merged

Introduce (i) Button Popover Component in HL7Monitor and VentilatorPatientVitalsMonitor #7228

merged 18 commits into from Feb 28, 2024

Conversation

thedevildude
Copy link
Contributor

@thedevildude thedevildude commented Feb 18, 2024 •
edited

Proposed Changes

image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@thedevildude thedevildude requested a review from a team as a code owner February 18, 2024 16:11
@vercel Vercel
Copy link

vercel bot commented Feb 18, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 2:26pm

@netlify Netlify
Copy link

netlify bot commented Feb 18, 2024 •
edited

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e5b67cf
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65d607c7d5e5260008cd1230
😎 Deploy Preview https://deploy-preview-7228--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor things

src/Components/VitalsMonitor/HL7PatientVitalsMonitor.tsx Outdated Show resolved Hide resolved
src/Components/VitalsMonitor/VentilatorPatientVitalsMonitor.tsx Outdated Show resolved Hide resolved
src/Components/VitalsMonitor/VitalsMonitorAssetPopover.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

@thedevildude
image

hide both ! and patient name is the asset configuration page, as they are irrelevant in that page.

@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 added tested reviewed reviewed by a core member and removed needs testing needs review labels Feb 26, 2024
@khavinshankar khavinshankar merged commit ab67826 into coronasafe:develop Feb 28, 2024
35 of 36 checks passed
@github-actions GitHub Actions
Copy link

@thedevildude We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@Ashesh3 Ashesh3 Awaiting requested review from Ashesh3

Assignees
No one assigned
Labels
reviewed reviewed by a core member tested
Projects
None yet
Milestone
No milestone
5 participants
@thedevildude @nihal467 @Ashesh3 @rithviknishad @khavinshankar