Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Minimum value in forms should be greater than 0 #7273

Merged
merged 9 commits into from
May 7, 2024

Conversation

Keshav-0907
Copy link
Contributor

Proposed Changes

Screen.Recording.2024-02-26.at.12.19.10.PM.mov

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Keshav-0907 Keshav-0907 requested a review from a team as a code owner February 26, 2024 06:50
Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 7:42pm

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c4280be
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6638bc95fc74bc0008282bf5
😎 Deploy Preview https://deploy-preview-7273--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Keshav-0907 Keshav-0907 changed the title Fix : Minimum value in triage form should be 0 Fix : Minimum value in forms should be 0 Feb 29, 2024
@Keshav-0907 Keshav-0907 changed the title Fix : Minimum value in forms should be 0 Fix : Minimum value in forms should be greater than 0 Feb 29, 2024
Copy link

vercel bot commented Apr 16, 2024

@nihal467 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 added needs review reviewed reviewed by a core member and removed needs review labels Apr 16, 2024
@khavinshankar khavinshankar added changes required and removed reviewed reviewed by a core member labels Apr 17, 2024
@khavinshankar khavinshankar merged commit 9a1c337 into coronasafe:develop May 7, 2024
26 of 29 checks passed
Copy link

github-actions bot commented May 7, 2024

@Keshav-0907 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a problem with this approach. These checks are valid only if the fields are "required". If no value is entered, the checks should still pass. However, that is not the case with this PR.

Fixed in #7775

cc: @Keshav-0907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug : Values in Forms can be Negative
5 participants