Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added minimum quantity in inventory list #7280

Conversation

balaji-sivasakthi
Copy link

@balaji-sivasakthi balaji-sivasakthi commented Feb 26, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Screenshot 2024-02-27 at 1 27 29 AM

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@balaji-sivasakthi balaji-sivasakthi requested a review from a team as a code owner February 26, 2024 19:45
Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 8:59pm

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit be4e9e1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65dcfb9846b69900087f2aff
😎 Deploy Preview https://deploy-preview-7280--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@balaji-sivasakthi
Copy link
Author

balaji-sivasakthi commented Feb 28, 2024

@nihal467 @rithviknishad ?

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are showing the default min. quantity instead of the configured min. quantity.

This requires changes in backend

@balaji-sivasakthi
Copy link
Author

Okay, I'll wait for this PR, ohcnetwork/care#1763, to merge.

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 12, 2024
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Minimum quantity data in the inventory list page
2 participants