Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced Reusable JSON Parser and Validator with Schema, File Preview, and Selected Import Support for XLSX/CSV Files #7367

Merged
merged 37 commits into from Apr 24, 2024
Merged

Introduced Reusable JSON Parser and Validator with Schema, File Preview, and Selected Import Support for XLSX/CSV Files #7367

merged 37 commits into from Apr 24, 2024

Conversation

UdaySagar-Git
Copy link
Contributor

@UdaySagar-Git UdaySagar-Git commented Mar 9, 2024 •
edited

Proposed Changes

  • Fixes Improve import UI for External Results Import #7333
  • Implemented a reusable JSON parser and validator with a specific schema for any JSON data
  • Converted a separate page for external result upload to a modal
  • Enhanced drag and drop functionality
  • Added file preview functionality for XLSX/CSV files
  • Replaced two packages with a single package

Features included in file viewer

  • Displays errors on hover
  • Provides pagination with selectable number of rows per page
  • Allows users to select specific rows for import
  • Blocks selection if the row has any errors

Screencast from 09-03-24 03:53:46 PM IST.webm
*screen recording feels laggy, but it was smooth in local development.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@UdaySagar-Git UdaySagar-Git requested a review from a team as a code owner March 9, 2024 10:55
@vercel Vercel
Copy link

vercel bot commented Mar 9, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 10:48pm

@netlify Netlify
Copy link

netlify bot commented Mar 9, 2024 •
edited

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 481d3fa
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6621a786e12c150008ce87fc
😎 Deploy Preview https://deploy-preview-7367--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@UdaySagar-Git
Copy link
Contributor Author

@rithviknishad @Ashesh3 can you please review this pr

@UdaySagar-Git
Copy link
Contributor Author

@rithviknishad can you please mark this as needs testing

@rithviknishad rithviknishad added needs testing and removed test failed Deploy-Failed Deplyment is not showing preview labels Apr 9, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @UdaySagar-Git,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 15, 2024
@nihal467
Copy link
Member

@UdaySagar-Git fix the merge conflict

@UdaySagar-Git UdaySagar-Git mentioned this pull request Apr 16, 2024
Closed
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Apr 17, 2024
@rithviknishad rithviknishad linked an issue Apr 18, 2024 that may be closed by this pull request
Auto-close import asset pop-up #7607
Closed
@rithviknishad
Copy link
Member

@UdaySagar-Git lint checks failing. upgrade the packages locally and fix the lints

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 18, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @UdaySagar-Git,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@UdaySagar-Git
Copy link
Contributor Author

@rithviknishad done!

@rithviknishad rithviknishad added needs testing and removed changes required merge conflict pull requests with merge conflict labels Apr 19, 2024
@khavinshankar khavinshankar merged commit 782a77d into coronasafe:develop Apr 24, 2024
25 of 29 checks passed
@github-actions GitHub Actions
Copy link

@UdaySagar-Git Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-close import asset pop-up Improve import UI for External Results Import
6 participants
@UdaySagar-Git @nihal467 @rithviknishad @Ashesh3 @khavinshankar @gigincg