Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Preview UIs and Changes to Painscale #7380

Merged
merged 10 commits into from
May 9, 2024

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented Mar 11, 2024

Dependent on coronasafe/care#1967

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@skks1212 skks1212 requested a review from a team as a code owner March 11, 2024 09:57
Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:01am

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4ec709f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/663c7496261468000877aa6b
😎 Deploy Preview https://deploy-preview-7380--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Mar 11, 2024

Passing run #2494 ↗︎

0 123 0 0 Flakiness 0

Details:

Updated Preview UIs and Changes to Painscale
Project: CARE Commit: 6d7642907c
Status: Passed Duration: 03:18 💡
Started: May 9, 2024 6:25 AM Ended: May 9, 2024 6:29 AM

Review all test suite changes for PR #7380 ↗︎

@nihal467
Copy link
Member

@skks1212
image

  • when i scroll the page, and keep exactly in the position as in the screenshot, then click on the right chest, the pop-up overlaps with the badges.
  • Keep the edges of the card as a curve, as we have curve border across the platform

@skks1212
Copy link
Member Author

@nihal467
the popup does that when it does not have space to appear below. Check this screenshot. I don't think this should have any UX problems. Other fixes are done.
image

@skks1212 skks1212 changed the title Updated Preview UIs Updated Preview UIs and Changes to Painscale Mar 12, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 19, 2024
Copy link

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

Copy link

github-actions bot commented Apr 9, 2024

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@nihal467
Copy link
Member

@skks1212 clear the merge conflict

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Apr 23, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 8, 2024
Copy link

github-actions bot commented May 8, 2024

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467 nihal467 added needs testing needs review P1 breaking issue or vital feature merge conflict pull requests with merge conflict and removed waiting for backend merge conflict pull requests with merge conflict labels May 8, 2024
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label May 8, 2024
@nihal467
Copy link
Member

nihal467 commented May 9, 2024

LGTM

@khavinshankar khavinshankar merged commit 15f7d44 into develop May 9, 2024
61 of 62 checks passed
@khavinshankar khavinshankar deleted the pressure-pain-preview branch May 9, 2024 07:07
Copy link

github-actions bot commented May 9, 2024

@skks1212 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pain Scale (0-10) UI Enhancement of the Pressure Sore and Pain Scale Preview Mode Log update- vitals
4 participants