Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue resolved "Handle the 0 Input in the Pressure sore and Pain Scale component" #7391

Merged
merged 5 commits into from Mar 19, 2024

Conversation

r-nikhilkumar
Copy link
Contributor

for width and height consistency:-

for PC:
image

for Mobile:
image

for the pressure 0 and painScale 0 issue:
you can check from git changed files

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@r-nikhilkumar r-nikhilkumar requested a review from a team as a code owner March 12, 2024 04:09
Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 6:21am

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 615dbef
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65f972a80d87ff0008a55472
😎 Deploy Preview https://deploy-preview-7391--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use prettier to format code

let region = PressureSore.regionToString(state.region)
if (state.length > 0.0 && state.width == 0.0) || (state.length == 0.0 && state.width > 0.0) {
if(state.length === 0.0 && state.width === 0.0){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(state.length === 0.0 && state.width === 0.0){
if(state.length === 0.0 && state.width === 0.0) {

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, check the linting once

…putModal.res

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
Copy link

vercel bot commented Mar 19, 2024

@nihal467 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit f00cd02 into coronasafe:develop Mar 19, 2024
34 of 35 checks passed
Copy link

@r-nikhilkumar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@r-nikhilkumar r-nikhilkumar deleted the PressurePain0Changes branch May 8, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle the 0 Input in the Pressure sore and Pain Scale component
5 participants