Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed unnecessary rendering of microphone permission warning info. #7404

Merged
merged 9 commits into from
Apr 9, 2024
Merged

fix: Removed unnecessary rendering of microphone permission warning info. #7404

merged 9 commits into from
Apr 9, 2024

Conversation

Spiral-Memory
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate the bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prepare a screenshot or demo video for the changelog entry, and attach it to the issue.
  • Request Peer Reviews
  • Completion of QA
2024-03-13.12-44-13.mp4

@Spiral-Memory Spiral-Memory requested a review from a team as a code owner March 13, 2024 07:17
@vercel Vercel
Copy link

vercel bot commented Mar 13, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 7:41am

@netlify Netlify
Copy link

netlify bot commented Mar 13, 2024 •
edited

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 96b6f1b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6613c7ea503e340008a0a0eb
😎 Deploy Preview https://deploy-preview-7404--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Spiral-Memory Spiral-Memory changed the title fixed unnecessary placement of mic permission info fix: Removed unnecessary rendering of microphone permission warning info. Mar 13, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 13, 2024 •
edited

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 7766f35
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/660d1d62f518ae00090421e8

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Mar 13, 2024
@Spiral-Memory Spiral-Memory force-pushed the issues/7403/fixed-rendering-mic-permission-warning branch from 11e3686 to dd279b5 Compare March 13, 2024 07:42
@vercel Vercel
Copy link

vercel bot commented Mar 13, 2024

@Spiral-Memory is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@Spiral-Memory Spiral-Memory force-pushed the issues/7403/fixed-rendering-mic-permission-warning branch from 202d30b to dd279b5 Compare March 13, 2024 07:51
@Spiral-Memory
Copy link
Contributor Author

@rithviknishad , please take a look at this PR. In the CodeClimate test, it is showing that a type definition should be included, but the file I changed is a JavaScript file. If I add a type definition, it will likely result in an error. Kindly review this PR, investigate this issue, and let me know. Thanks.

@Spiral-Memory Spiral-Memory force-pushed the issues/7403/fixed-rendering-mic-permission-warning branch from dd279b5 to ff96f59 Compare March 13, 2024 08:31
@rithviknishad rithviknishad added needs testing needs review and removed Deploy-Failed Deplyment is not showing preview labels Mar 13, 2024
@Spiral-Memory
Copy link
Contributor Author

Hey @rithviknishad Could you please look into this once ?

@rithviknishad rithviknishad added reviewed reviewed by a core member and removed needs review labels Mar 18, 2024
@nihal467
Copy link
Member

image

@Spiral-Memory
Copy link
Contributor Author

image

Could you please explain a little, like what's the problem ?

When permission is not there.. that warming will be shown otherwise it's not. Please refer to the video on how i intended it to be.

If you require any change, please let me know !

@rithviknishad
Copy link
Member

Hey @Spiral-Memory

Let us just confirm that doing this is okay as IIRC this was kept intentionally, don't remember the reason.

@Spiral-Memory
Copy link
Contributor Author

Hey @Spiral-Memory

Let us just confirm that doing this is okay as IIRC this was kept intentionally, don't remember the reason.

Sure @rithviknishad !

@gigincg
Copy link
Member

gigincg commented Mar 20, 2024

@Spiral-Memory @nihal467 @rithviknishad

Following is the expected Behaviour:

Warning as span :

  • Shown when Permission is not granted
  • Hidden when Permission is already granted

Warning as notification:

  • Shown when Permission is not granted & User clicks on Record button

@nihal467 nihal467 added needs review and removed reviewed reviewed by a core member labels Apr 3, 2024
rithviknishad
rithviknishad reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor suggestions

src/Components/Patient/FileUpload.tsx Outdated Show resolved Hide resolved
src/Components/Patient/FileUpload.tsx Outdated Show resolved Hide resolved
src/Components/Patient/FileUpload.tsx Outdated Show resolved Hide resolved
@rithviknishad
Copy link
Member

Also fix the lint errors

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Apr 3, 2024
Spiral-Memory and others added 8 commits April 3, 2024 15:02
@Spiral-Memory
fixed unnecessary placement of mic permission info
4c73340
@Spiral-Memory
added type void
06014c2
@Spiral-Memory
mic warning to render when mic permission is not enabled
3a8fcf5
@Spiral-Memory
fixed auto mic permission popup
064cd08
@Spiral-Memory @rithviknishad
Update src/Components/Patient/FileUpload.tsx
a63f7ba 
Suggested changes applied 1

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
@Spiral-Memory @rithviknishad
Update src/Components/Patient/FileUpload.tsx
fb0a104 
Suggested changes applied 2

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
@Spiral-Memory @rithviknishad
Update src/Components/Patient/FileUpload.tsx
99ef687 
Suggested changes applied 3

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
@Spiral-Memory
fixed lint errors
3b436ec
@Spiral-Memory Spiral-Memory force-pushed the issues/7403/fixed-rendering-mic-permission-warning branch from 88b4fdc to 3b436ec Compare April 3, 2024 09:32
@nihal467
Copy link
Member

nihal467 commented Apr 8, 2024

lgtm

@khavinshankar khavinshankar merged commit d615772 into coronasafe:develop Apr 9, 2024
33 of 35 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

@Spiral-Memory Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
cypress passed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Unnecessary rendering Mic Permission warning even if mic permission is enabled
6 participants
@Spiral-Memory @nihal467 @rithviknishad @gigincg @Ashesh3 @khavinshankar