Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Age field in patient registration #7411

Merged
merged 27 commits into from
Apr 3, 2024
Merged

Conversation

rash-27
Copy link
Contributor

@rash-27 rash-27 commented Mar 14, 2024

Required Backends

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rash-27 rash-27 requested a review from a team as a code owner March 14, 2024 06:41
Copy link

vercel bot commented Mar 14, 2024

@rash-27 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4387e75
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/660c498399dfb2000818076a
😎 Deploy Preview https://deploy-preview-7411--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad added the P1 breaking issue or vital feature label Mar 14, 2024
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be pushing the changes for the below review...

src/Components/Patient/PatientRegister.tsx Outdated Show resolved Hide resolved
src/Components/Patient/PatientRegister.tsx Outdated Show resolved Hide resolved
src/Components/Patient/PatientRegister.tsx Outdated Show resolved Hide resolved
src/Components/Patient/PatientRegister.tsx Outdated Show resolved Hide resolved
src/Components/Patient/PatientRegister.tsx Outdated Show resolved Hide resolved
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes were missing for using the year_of_birth/age/age_days field for representing age if date_of_birth is null. I've added them

@rithviknishad rithviknishad marked this pull request as ready for review March 18, 2024 13:01
Copy link

👋 Hi, @rash-27,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rash-27
Copy link
Contributor Author

rash-27 commented Mar 23, 2024

  • @rithviknishad I have deleted that cypress test and modified other tests to verify age , and they are passing with the local backend
    Screenshot from 2024-03-24 03-51-35

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

👋 Hi, @rash-27,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 2182ad3
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/660c3d0bb6ff4c0008c3a467

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Apr 2, 2024
@rithviknishad rithviknishad removed Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict waiting for backend labels Apr 2, 2024
@khavinshankar khavinshankar merged commit da31e66 into coronasafe:develop Apr 3, 2024
32 of 35 checks passed
Copy link

github-actions bot commented Apr 3, 2024

@rash-27 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect representation of Patient Age
5 participants