Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7458 #7462

Conversation

kabirrajsingh
Copy link
Contributor

Proposed Changes

[- Fixes #7458

  • Fixes issue 1 and 2 by adding a new isFileTypeSupported function which uses the file signature's header to check for the file type.
  • Only when the filetype is verified, the api call to backend is made
  • Fixes issue 3 by adding reset functions

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  1. Discussion for finalizing the supported file types. Currently supported file types are .png, .jpeg, .jpg, .mp3, .midi, .wav, .pdf

@kabirrajsingh kabirrajsingh requested a review from a team as a code owner March 23, 2024 13:07
Copy link

vercel bot commented Mar 23, 2024

@kabirrajsingh is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for care-egov-staging failed.

Name Link
🔨 Latest commit c95b52e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66250339b5b93f0008ac7676

Copy link

👋 Hi, @kabirrajsingh,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 28, 2024
Copy link

github-actions bot commented Apr 5, 2024

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 5, 2024
Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit c95b52e
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/66250339a0c5ad000823bc4b

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Apr 5, 2024
@kabirrajsingh
Copy link
Contributor Author

@rithviknishad pease review this

@github-actions github-actions bot removed stale merge conflict pull requests with merge conflict labels Apr 6, 2024
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 15, 2024
@nihal467
Copy link
Member

@kabirrajsingh there is a deploy failure, might be a type check failing, check it

@kabirrajsingh
Copy link
Contributor Author

@nihal467 yes I will fix this and #7309 by end of the week. Sorry for the delay, little busy with final year exams.

@github-actions github-actions bot removed the stale label Apr 17, 2024
@nihal467
Copy link
Member

@kabirrajsingh can you provide an update on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required Deploy-Failed Deplyment is not showing preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple issues with validateFileUpload function in src/patient/fileUpload.ts
3 participants