Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Solved facility linking issue under manage facilities/view users"#7474 #7494

Merged

Conversation

Sulochan-khadka
Copy link
Contributor

@Sulochan-khadka Sulochan-khadka commented Mar 29, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Sulochan-khadka Sulochan-khadka requested a review from a team as a code owner March 29, 2024 11:01
Copy link

vercel bot commented Mar 29, 2024

@Sulochan-khadka is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c8c38d8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66069f9a52af6f0008604249
😎 Deploy Preview https://deploy-preview-7494--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 68efb17
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/661e1d6bd56de90008730528
😎 Deploy Preview https://deploy-preview-7494--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mridulsaggi
Copy link

please assign me this issue as i am willing to work on this.

@Sulochan-khadka
Copy link
Contributor Author

please assign me this issue as i am willing to work on this.

Hey mate, sadly this is a PR and not an issue, therefore if you want to solve an issue, kindly explore the issue tab.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

👋 Hi, @Sulochan-khadka,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 10, 2024
@Sulochan-khadka
Copy link
Contributor Author

@rithviknishad let me know the way out for this PR to get merged. Thankyou

@github-actions github-actions bot removed the stale label Apr 12, 2024
@rithviknishad rithviknishad added needs testing needs review merge conflict pull requests with merge conflict and removed changes required merge conflict pull requests with merge conflict needs testing needs review labels Apr 13, 2024
@rithviknishad
Copy link
Member

@rithviknishad let me know the way out for this PR to get merged. Thankyou

Could you resolve the merge conflicts?

@Sulochan-khadka
Copy link
Contributor Author

@rithviknishad let me know the way out for this PR to get merged. Thankyou

Could you resolve the merge conflicts?

I will do it right away...

@Sulochan-khadka
Copy link
Contributor Author

@rithviknishad let me know the way out for this PR to get merged. Thankyou

Could you resolve the merge conflicts?

Done...

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Apr 13, 2024
Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 03a0b7d
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/661d6dc09acc18000876c1c3

@Sulochan-khadka
Copy link
Contributor Author

@rithviknishad , I also solved a minor error that was causing the deployment to fail. You may have a look.

@nihal467 nihal467 removed Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict labels Apr 14, 2024
@nihal467 nihal467 added needs testing needs review bug Something isn't working labels Apr 14, 2024
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, just resolve the linting issues and remove the comments used for todo reminders

@nihal467
Copy link
Member

@Sulochan-khadka make the necessary changes

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Apr 15, 2024
@Sulochan-khadka
Copy link
Contributor Author

@nihal467 @khavinshankar have fixed almost all lint errors... Well I did not find one lint error the workflow was indicating at... replacing ... with '....' , when there is no such statement . Do let me know immediately if unknowingly I messed up something. Also have just commented out showFacilites since it might be of use in future.

@rithviknishad rithviknishad removed bug Something isn't working Deploy-Failed Deplyment is not showing preview labels Apr 16, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit d6bce0f into coronasafe:develop Apr 16, 2024
26 of 29 checks passed
Copy link

@Sulochan-khadka Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facilities added but not displayed in Users.
5 participants