Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon overlapping with text in text-box of Doctor's Notes. #7495 #7496

Conversation

Sulochan-khadka
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Sulochan-khadka Sulochan-khadka requested a review from a team as a code owner March 29, 2024 18:18
Copy link

vercel bot commented Mar 29, 2024

@Sulochan-khadka is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ba2aaf4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6638bb6591914f0008ec8558
😎 Deploy Preview https://deploy-preview-7496--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

👋 Hi, @Sulochan-khadka,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad
Copy link
Member

Hey @Sulochan-khadka
Could you resolve the merge conflict?

@Sulochan-khadka
Copy link
Contributor Author

Hey @Sulochan-khadka Could you resolve the merge conflict?

Yeah sure... I will do...

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 11, 2024
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 147ca2a
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/66178daa5dac410008f9ea4e

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Apr 11, 2024
@Sulochan-khadka
Copy link
Contributor Author

@rithviknishad have solved merge conflicts... Kindly have a look.

@rithviknishad rithviknishad added needs testing needs review and removed Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict stale labels Apr 11, 2024
@nihal467
Copy link
Member

nihal467 commented Apr 16, 2024

@Sulochan-khadka the UI doesn't look good, can you try to implement Ui similar to slack

image

@Sulochan-khadka
Copy link
Contributor Author

@nihal467 sure... But then I need to make changes to another issue that was solving that of patient's notes. Shall I go ahead and make your suggested changes on both?

@Sulochan-khadka
Copy link
Contributor Author

@Sulochan-khadka the UI doesn't look good, can you try to implement Ui similar to slack

image

Should I add a rich text editor ? something like react-quill? Or you just want to correct the alignment . I think adding something like react quill will obviously be a firm step towards improving the doctor's notes functionality for example, adding markdown feature and file upload functionality. Let me know your thoughts on this.

@nihal467
Copy link
Member

@rithviknishad can you comment on this issue

@rithviknishad
Copy link
Member

rithviknishad commented Apr 23, 2024

@Sulochan-khadka I'd suggest creating a separate issue for that as that would be a larger change and the related issue simply needs to solve the icon overlapping issue and have a good UI.

@nihal467
Copy link
Member

nihal467 commented May 7, 2024

LGTM

@khavinshankar khavinshankar merged commit 24c0ce1 into coronasafe:develop May 7, 2024
28 of 30 checks passed
Copy link

github-actions bot commented May 7, 2024

@Sulochan-khadka Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon overlapping with text in text-box of Doctor's Notes.
4 participants