Show no information card if consultation and sample test history list is empty #7502
Conversation
|
@Sulochan-khadka is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Give a meaningful title to the PR
Refer: https://github.com/coronasafe/care_fe?tab=readme-ov-file#contributing-to-care
| <div className=" w-full px-12"> | ||
| <AutoExpandingTextInputFormField | ||
| id="doctor_notes_textarea" | ||
| maxHeight={160} | ||
| rows={1} | ||
| name="note" | ||
| value={noteField} | ||
| onChange={(e) => setNoteField(e.value)} | ||
| className="grow" | ||
| errorClassName="hidden" | ||
| placeholder="Type your Note" | ||
| disabled={!patientActive} | ||
| onFocus={() => setFocused(true)} | ||
| onBlur={() => setFocused(false)} | ||
| /> | ||
| </div> | ||
| <div className="flex items-center"> | ||
| <ButtonV2 | ||
| id="add_doctor_note_button" | ||
| onClick={onAddNote} | ||
| border={false} | ||
| className="absolute right-2" | ||
| ghost | ||
| size="small" | ||
| disabled={!patientActive} | ||
| authorizeFor={NonReadOnlyUsers} | ||
| > | ||
| <CareIcon className="care-l-message text-lg" /> | ||
| </ButtonV2> | ||
| </div> |
There was a problem hiding this comment.
Why was this changed? Totally unrelated to the issue being solved right?
There was a problem hiding this comment.
To Make the layout better... Since very soon, upload icon will also be added and so thought making a layout before would be better. Just rearrangement, thats it. Will remove if you say.
There was a problem hiding this comment.
Unrelated to the issue being solved by this PR. Feel free to file a separate issue if so.
There was a problem hiding this comment.
Should I remove them and file separate issue for this as well?
There was a problem hiding this comment.
Just saw this was addressed in another PR. Need not file an issue
There was a problem hiding this comment.
Yeah... actually that was addressed before this, both by me, therefore, it happened so.
There was a problem hiding this comment.
Also changed the title as was instructed.
There was a problem hiding this comment.
@Sulochan-khadka you've not pushed any changes plus the PR title still doesn't make sense. Refer the above link and see other PR's for example...
|
👋 Hi, @Sulochan-khadka, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
rithviknishad
added
changes required
and removed
merge conflict
Sulochan-khadka
changed the title
|
👋 Hi, @Sulochan-khadka, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
|
Have removed the unrelated code... @rithviknishad Let me have a review of yours... |
Sulochan-khadka
changed the title
|
@rithviknishad , I have resolved the conflicts. Kindly do the needful. Thanks |
rithviknishad
added
needs testing
and removed
changes required
merge conflict
|
|
nihal467
added
made_changes
changes required
and removed
needs review
made_changes
labels
I think I implemented what you suggested... Let me know if I got it wrong... |
|
@nihal467 kindly have a review . |
|
@nihal467 @Ashesh3 @rithviknishad kindly get this merged soon. Let me know if some modifications are required from my side. Thankyou. |
rithviknishad
changed the title
|
LGTM |
|
@Sulochan-khadka Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist