Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace react-qr-reader with @yudiel/react-qr-scanner package #7537

Merged
merged 9 commits into from
Apr 24, 2024
Merged

Replace react-qr-reader with @yudiel/react-qr-scanner package #7537

merged 9 commits into from
Apr 24, 2024

Conversation

thedevildude
Copy link
Contributor

@thedevildude thedevildude commented Apr 4, 2024 •
edited

Proposed Changes

  • Fixes Replace react-qr-scanner package #7505
  • Replaced deprecated package react-qr-reader with @yudiel/react-qr-scanner
  • Updated AssetsList, QRScanner and AssetCreate components with new QR code scanner package
react-qr-reader (old) @yudiel/react-qr-scanner (new)
Unpacked Size 4.38 MB Unpacked Size: 5.08 MB
Inactive repository, last update 2 years ago Newer package with active updates
Minimal documentation Better documentation with good TypeScript support
Lacking support for multi camera devices Provides hooks for choosing between different camera devices
Basic APIs Better APIs, with extensive options for customizations and custom hooks

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel Vercel
Copy link

vercel bot commented Apr 4, 2024

@thedevildude is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@netlify Netlify
Copy link

netlify bot commented Apr 4, 2024 •
edited

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f46fe09
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66249e03a0c5ad00081d7c0a
😎 Deploy Preview https://deploy-preview-7537--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 12, 2024
@github-actions github-actions bot removed the stale label Apr 14, 2024
@thedevildude
removed faulty qr code scanner package
e61220a
@thedevildude
Update package-lock.json and package.json to include "@yudiel/react-q…
9246320 
…r-scanner" package version 2.0.0-beta.3. Update AssetsList.tsx to import Scanner from "@yudiel/react-qr-scanner" instead of QrReader.
@thedevildude
Update QR code scanner package and replace deprecated QrReader with S…
2a895b6 
…canner component from "@yudiel/react-qr-scanner" package.
@thedevildude
Replaced deprecated package react-qr-reader with @yudiel/react-qr-sca…
41de7f7 
…nner
@thedevildude thedevildude marked this pull request as ready for review April 14, 2024 17:23
@thedevildude thedevildude requested a review from a team as a code owner April 14, 2024 17:23
@nihal467
Copy link
Member

LGTM

khavinshankar
khavinshankar reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thedevildude can you please add a short write-up on why this package was replaced, like the pros and cons compared to the old one that was replaced?

@khavinshankar khavinshankar added the question Further information is requested label Apr 17, 2024
@thedevildude thedevildude changed the title Replace react-qr-reader with reactjs-qr-code-reader package Replace react-qr-reader with @yudiel/react-qr-scanner package Apr 17, 2024
@rithviknishad rithviknishad removed the question Further information is requested label Apr 22, 2024
@khavinshankar khavinshankar merged commit 3cd0dca into coronasafe:develop Apr 24, 2024
27 of 29 checks passed
@github-actions GitHub Actions
Copy link

@thedevildude Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@thedevildude thedevildude deleted the fix#7505 branch April 24, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad Awaiting requested review from rithviknishad

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace react-qr-scanner package
5 participants
@thedevildude @nihal467 @Ashesh3 @khavinshankar @rithviknishad