Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search by typing in symptoms #7551

Merged
merged 21 commits into from
Apr 24, 2024
Merged

Conversation

hrit2773
Copy link
Contributor

@hrit2773 hrit2773 commented Apr 5, 2024

@hrit2773 hrit2773 requested a review from a team as a code owner April 5, 2024 17:03
Copy link

vercel bot commented Apr 5, 2024

@hrit2773 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 667bc05
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6627bbb8a0211500082f85eb
😎 Deploy Preview https://deploy-preview-7551--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Apr 6, 2024

@hrit2773 fix the cypress issue

@hrit2773
Copy link
Contributor Author

hrit2773 commented Apr 7, 2024

  1. Patient Consultation in multiple combination
    OP Patient with admission consultation:
    AssertionError: Timed out retrying after 10000ms: Expected to find element: [role='option'], but never found it.
    at Context.eval (webpack://care_fe/./cypress/support/commands.ts:131:0)

  2. Patient Consultation in multiple combination
    OP Patient with Declare Death:
    AssertionError: Timed out retrying after 10000ms: Expected to find element: [role='option'], but never found it.
    at Context.eval (webpack://care_fe/./cypress/support/commands.ts:131:0)

  3. Patient Consultation in multiple combination
    Internal Transfer within facility Patient with Domicilary Care:
    AssertionError: Timed out retrying after 10000ms: Expected to find element: [role='option'], but never found it.
    at Context.eval (webpack://care_fe/./cypress/support/commands.ts:131:0)

  4. Patient Consultation in multiple combination
    Referred From another Facility Patient with OP consultation:
    AssertionError: Timed out retrying after 10000ms: Expected to find element: [role='option'], but never found it.
    at eval (webpack://care_fe/./cypress/support/commands.ts:122:0)
    at Array.forEach ()
    at Context.eval (webpack://care_fe/./cypress/support/commands.ts:121:0)

  5. Patient Consultation in multiple combination
    OP Patient with Refer to another hospital consultation:
    AssertionError: Timed out retrying after 10000ms: Expected to find element: [role='option'], but never found it.
    at eval (webpack://care_fe/./cypress/support/commands.ts:122:0)
    at Array.forEach ()
    at Context.eval (webpack://care_fe/./cypress/support/commands.ts:121:0)

@nihal467 what is this [role='option'] how to track them

@hrit2773
Copy link
Contributor Author

hrit2773 commented Apr 7, 2024

@Nihal i just made changes to autoCompleteMultiSelect component. I think this issue has nothing to do with the patient op declare death or domiciliary care. And i didnt make any changes to the field attributes or selectors, maybe cypress is unable to get the selectors of the components...just tell me if im missing something. Can you tell me more about these cypress tests configurations because the consultation form is working completely fine

@nihal467
Copy link
Member

nihal467 commented Apr 8, 2024

image
@hrit2773

  • Go to the patient_consultation.cy.ts file and modify the patientconsultationpage.selectsymptoms().
  • Since we don't have search and multi-select reusable selector components, create a component in the command.ts file for Cypress, and use it to select symptoms in the function.

@hrit2773
Copy link
Contributor Author

@nihal467 all the cypress test passed

@nihal467
Copy link
Member

@hrit2773
image

  • when a user click the option "asymptomatic", it should auto-close the component, your PR is not preserving the existing behavior in our current staging

@hrit2773
Copy link
Contributor Author

@nihal467 I see...will fix it

@hrit2773
Copy link
Contributor Author

hrit2773 commented Apr 21, 2024

@nihal467 why are the commas getting excluded during the commit the lint test is failing is it due the changes in prettier? because even if iam adding the commas its considering it as empty commit. @rithviknishad

@rithviknishad
Copy link
Member

Try reinstalling the packages locally. There was a recent version change.

@hrit2773
Copy link
Contributor Author

@rithviknishad @nihal467 now i added auto close for single select also so it is preserving the previous behaviour of closing the component as soon as user clicks on Asymptomatic.

@khavinshankar khavinshankar merged commit 30a97d1 into coronasafe:develop Apr 24, 2024
27 of 29 checks passed
Copy link

@hrit2773 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search by typing in symptoms list
5 participants