Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for various abha qr in scan and pull #7565

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

khavinshankar
Copy link
Member

Proposed Changes

The QR generated from the different apps varies slightly, added support for the scan and pull regardless of the variation.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team as a code owner April 8, 2024 01:40
Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Apr 8, 2024 1:40am

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1bb97f9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66134b0842bea800088ddf5b
😎 Deploy Preview https://deploy-preview-7565--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Apr 8, 2024

Passing run #2348 ↗︎

0 119 0 0 Flakiness 0

Details:

Added support for various abha qr in scan and pull
Project: CARE Commit: 1bb97f943c
Status: Passed Duration: 03:09 💡
Started: Apr 8, 2024 1:44 AM Ended: Apr 8, 2024 1:48 AM

Review all test suite changes for PR #7565 ↗︎

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@nihal467
Copy link
Member

LGTM

@gigincg gigincg merged commit 48db450 into develop Apr 18, 2024
66 of 67 checks passed
@gigincg gigincg deleted the scan-and-pull branch April 18, 2024 10:52
Copy link

@khavinshankar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants