Fix Notifications for Facility Cover Image Deletion #7609
Conversation
|
@AnkurPrabhu is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@rithviknishad we already had notification for deletion its just that due to re-renders it does not show it. this should fix it |
| <CareIcon icon="l-save" className="text-lg" /> | ||
| )} | ||
| <span> | ||
| {isDeleting ? `${t("Deleting")}...` : `${t("delete")}`} |
There was a problem hiding this comment.
why are we using capital key Deleting? 🤔
There was a problem hiding this comment.
will change it to deleting
| {isDeleting ? ( | ||
| <CareIcon | ||
| icon="l-spinner" | ||
| className="animate-spin text-lg" | ||
| /> | ||
| ) : ( | ||
| <CareIcon icon="l-save" className="text-lg" /> | ||
| )} | ||
| <span> | ||
| {isDeleting ? `${t("Deleting")}...` : `${t("delete")}`} |
There was a problem hiding this comment.
Don't we have something simlar to disabling cover that disables the entrie action on save?
There was a problem hiding this comment.
i just used what we already do for upload we just wanted a re-render to happen here in order to fix the bug, should i remove it ?
|
pls take a look @bodhish |
|
LGTM |
|
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
|
LGTM |
There was a problem hiding this comment.
@AnkurPrabhu can u also move the constants (that doesn't depend on any state) outside the function
@khavinshankar can you explain as in what do you mean by constants here |
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
screenshot:
