Fixed #7610 Toggle Emergency Contact No. From Phone Number #7644
Conversation
|
@manasvi-gaur is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for care-net failed.
|
|
@rithviknishad can you review the PR |
rithviknishad
added
cypress failed
|
@manasvi-gaur Tests are failing. Cypress tests needs to be updated |
| value={ | ||
| isEmergencyNumberEnabled | ||
| ? field("phone_number").value | ||
| : initForm.emergency_phone_number | ||
| } |
There was a problem hiding this comment.
This will cause issues as the displayed value may not be the one that is sent in the POST request.
Update form state for emergency phone number instead of displaying a different value conditionally.
…er' of https://github.com/manasvi-gaur/care_fe into Fixes#7610_Toggle_Emergency_Contact_No._From_Phone_Number
| emergency_phone_number: parsePhoneNumber(formData.emergency_phone_number), | ||
| emergency_phone_number: isEmergencyNumberEnabled | ||
| ? parsePhoneNumber(formData.phone_number) | ||
| : parsePhoneNumber(formData.emergency_phone_number), |
There was a problem hiding this comment.
Avoid changing this here.
Let's keep the formData / form state the source of truth.
|
@manasvi-gaur can you fix the issues ASAP |
|
@nihal467 okay |
|
@rithviknishad I have made all relevant changes but I am unable to get cypress test failing reason, can you tell what updates do i have to make in cypress ? |
|
@manasvi-gaur the patient registration cypress tests need to be modified to account for the changes made in this PR. Also ensure lint checks are passing. Ensure prettier is configured in your local and has latest packages installed. |
rithviknishad
added
needs testing
needs review
and removed
changes required
cypress failed
|
rithviknishad
added
needs testing
Cypress Test Pending
|
LGTM |
nihal467
added
tested
and removed
needs testing
Cypress Test Pending
|
@manasvi-gaur Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers