Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue preventing from administering down titration prescriptions #7743

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Fixes issue preventing from administering down titration prescriptions #7743

merged 2 commits into from
Apr 30, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Fixes Fix the existing malfunctioning validation for titrated dose #7742
  • Improve the responsiveness of Create and Edit prescription forms.
  • Fixes issue with validation that prevented administration for down titration prescriptions.
  • Fixes issue with edit prescription showing error "No changes present" when only target dosage is changed for titrated prescriptions

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner April 30, 2024 11:57
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:48pm

@netlify Netlify
Copy link

netlify bot commented Apr 30, 2024 •
edited

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 28950bd
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/663120ad81e1d000081d978b
😎 Deploy Preview https://deploy-preview-7743--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad added the P1 breaking issue or vital feature label Apr 30, 2024
@cypress Cypress
Copy link

cypress bot commented Apr 30, 2024 •
edited

Passing run #2458 ↗︎

0 122 0 0 Flakiness 0

Details:

Fixes issue preventing from administering down titration prescriptions
Project: CARE Commit: 28950bdb57
Status: Passed Duration: 02:53 💡
Started: Apr 30, 2024 4:52 PM Ended: Apr 30, 2024 4:55 PM

Review all test suite changes for PR #7743 ↗︎

@nihal467
Copy link
Member

@rithviknishad
image

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 4568e5f into develop Apr 30, 2024
60 checks passed
@khavinshankar khavinshankar deleted the issues/7742/titrated-administration-validation-fix branch April 30, 2024 18:31
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@Ashesh3 Ashesh3 Awaiting requested review from Ashesh3

Assignees
No one assigned
Labels
needs review P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the existing malfunctioning validation for titrated dose
3 participants
@rithviknishad @nihal467 @khavinshankar