Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show loading state when switching tabs in Discussion Notes #7819

Merged
merged 4 commits into from
May 22, 2024
Merged

Show loading state when switching tabs in Discussion Notes #7819

merged 4 commits into from
May 22, 2024

Conversation

sunny-thakurwar
Copy link
Contributor

@sunny-thakurwar sunny-thakurwar commented May 14, 2024 •
edited
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sunny-thakurwar sunny-thakurwar requested a review from a team as a code owner May 14, 2024 19:45
@vercel Vercel
Copy link

vercel bot commented May 14, 2024

@sunny-thakurwar is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@netlify Netlify
Copy link

netlify bot commented May 14, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ecf7b88
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/664dc3b93e9cc70008da33eb
😎 Deploy Preview https://deploy-preview-7819--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sunny-thakurwar
Copy link
Contributor Author

sunny-thakurwar commented May 14, 2024 •
edited
Loading

@rithviknishad its is with reference to issue #7818. can you please check once.

rithviknishad
rithviknishad requested changes May 15, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM. However changes needs to be present in Patient Notes too. This changes only for Consultation Notes.

For reference, this page: https://deploy-preview-7819--care-net.netlify.app/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/notes

@sunny-thakurwar
Copy link
Contributor Author

@rithviknishad Thank you for the feedback. The requested changes have been applied to the patient Notes. can you can review the current implementation.

@sunny-thakurwar
Copy link
Contributor Author

@rithviknishad updated the branch with develop. might required approval again

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 8582bbd into coronasafe:develop May 22, 2024
29 of 30 checks passed
@github-actions GitHub Actions
Copy link

@sunny-thakurwar Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show loading state when switching tabs in Discussion Notes
4 participants
@sunny-thakurwar @nihal467 @rithviknishad @khavinshankar