-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prescriptions: Default Discontinued Prescriptions Collapsed #7833
Prescriptions: Default Discontinued Prescriptions Collapsed #7833
Conversation
@Sulochan-khadka is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, however there is one problem. For active prescriptions, if we click on one of the buttons (administer/discontinue), the shrinked state of the card also changes. This is not expected behaviour.
@Sulochan-khadka you might also want to update the cypress tests are related test is failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi, @Sulochan-khadka, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@Sulochan-khadka newly added active medicine is getting by-default collapsed state, which is not expected, only discontinued medicine should be in collapsed state bydefault. Steps to replicate
|
LGTM |
@rithviknishad create a new PR to sort the prescription table to show live medicine on the top |
@Sulochan-khadka Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist