Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate page for patient consent records #7882

Merged
merged 15 commits into from
May 24, 2024
Merged

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented May 22, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@skks1212 skks1212 requested a review from a team as a code owner May 22, 2024 13:17
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 5:14pm

Copy link

netlify bot commented May 22, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit afce506
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6650cad37c3c0700085f2411
😎 Deploy Preview https://deploy-preview-7882--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented May 22, 2024

Passing run #2621 ↗︎

0 124 0 0 Flakiness 0

Details:

Separate page for patient consent records
Project: CARE Commit: 28b0b2a5fa
Status: Passed Duration: 02:54 💡
Started: May 24, 2024 2:17 PM Ended: May 24, 2024 2:20 PM

Review all test suite changes for PR #7882 ↗︎

Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
@aparnacoronasafe
Copy link
Member

aparnacoronasafe commented May 22, 2024

Issues noted:

1- when "patient code status for a patient is updated for the first time (within an encounter), this pop-up window need not come up
image

2- when I type file name before selecting file, the name of the file I select replaces the file name I typed. This shouldn't happen. Only when the file name field is empty should the name of file uploaded come up there

3- when I uploaded patient code for the first time "permission denied" error came up alongside success message. The first workflow was good, but the error message is misplaced

4- small alignment issue view button on mobile screen
image

5- I first filed a patient code status DNH. Then I filed one for active treatment. The heading - patient code status continued to show DNH. When I tried to update the patient code status the pop up window also said I am changing it from DNH (it should have been active treatment since that is the latest code status)
image

6- each document uploaded for patient code status must say what kind of code status it was. Most likely the nurses won't be writing the detail in file name. Then as the user looks at the log of file for code status, we will have no clue what kind they are!

7- when user deletes a consent record, we need a greyed text appear in the log " name of user (username) deleted a record."
If it's code status, mention " name of user (username) deleted a record for code status"

@khavinshankar
Copy link
Member

@skks1212 can you make the above recommended changes

cc: @nihal467

@khavinshankar khavinshankar added urgent P1 breaking issue or vital feature labels May 22, 2024
@skks1212
Copy link
Member Author

skks1212 commented May 22, 2024

@aparnacoronasafe changes have been made.
I have replaced "delete" with archive. This will allow you to see archived consents in the new tab.

I could not add the "nurse changed x" logs as that would require a backend PR. If the current solution does not work, then I will make that.

@nihal467
Copy link
Member

nihal467 commented May 23, 2024

image

  • keep the archive individual file level
  • create a backend PR to record who uploaded and arcive the respective file, ( Front-end changes to reflect this data can be done next week as enhancement )

@nihal467
Copy link
Member

nihal467 commented May 24, 2024

image

  • keep only individual file level archive only

image

  • can we keep the file preview ( Left side ) and file upload component (Right side) into same level , expected behavior screenshot is attached in the bottom

image

@skks1212

Copy link
Member

@nihal467 nihal467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the minor changes in the comment

@nihal467
Copy link
Member

nihal467 commented May 24, 2024

@skks1212
image

when i click on the consent record, the bed pop-up is triggered, it is not a necessary to have a bed assigned to the patient

image

when i archive a file, the page state is not changing, i need to manually refresh the page to view the archive file changes

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

nihal467 commented May 24, 2024

image

  • once the file is archived, make the button similar to file upload

image

  • any file uploaded by a user, should be only allowed to archive by the same user, and admin-only users ( Similar behavior is used in the file upload component)

image

  • if there is no file available, it should be showing a white card saying no file available similar behavior in the file upload component)

image

@khavinshankar
Copy link
Member

  • No records found
    image
  • Hide Archive button for non-admin users (except for the original user who uploaded it)
    image

@nihal467
Copy link
Member

Approved due to priority, enhancement issue will be opened after merging

@khavinshankar khavinshankar merged commit 63a2cdb into develop May 24, 2024
23 of 33 checks passed
@khavinshankar khavinshankar deleted the consent-record-page branch May 24, 2024 18:11
Copy link

@skks1212 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Copy link

sentry-io bot commented Jun 5, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Failed to fetch downloadFileUrl(src/Utils/useFileManager) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review P1 breaking issue or vital feature urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement to the Existing consent form Implementation
5 participants