Restructured Consent Records #7946

skks1212 · 2024-05-30T19:03:42Z

Dependant on coronasafe/care#2209 and coronasafe/care#2251

Proposed Changes

Fixes Enhancement to the Patient consent #7921

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

vercel · 2024-05-30T19:03:45Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 7, 2024 6:49am

netlify · 2024-05-30T19:04:00Z

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`0c5dbbb`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/6662ad4b6434870008d6b180
😎 Deploy Preview	https://deploy-preview-7946--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress · 2024-05-30T19:13:18Z

Passing run #2716 ↗︎

0	124	0	0	0

Details:

Restructured Consent Records
Project: CARE	Commit: `1ca8767a7c`
Status: Passed	Duration: 03:24 💡
Started: Jun 6, 2024 5:08 PM	Ended: Jun 6, 2024 5:11 PM

Review all test suite changes for PR #7946 ↗︎

skks1212 · 2024-05-31T01:22:43Z

Cypress failing due to unavailable endpoints. Should work after backend PR is merged

nihal467 · 2024-05-31T10:22:36Z

@skks1212 @gigincg

Bug

as per issue, if all existing uploaded files are archived and no active file are present, the consent missing badge should appear in the consultation, but in the PR, it is not behaving as expect

when user uploads a .xlsx file, the process will get completed, but preview mode will fail. In existing consultation file upload, .xlsx format doesn't have preview. So, as a solution, it's better to restrict upload on consent to support only images and pdf formats

Additional Enhancement for Better User Experience

Add a edit button for users, in case they want to modify the file name

once a file is archived, you should replace upload by user name with the username who archived it
since you are replacing username based on the above comment, add the created by and at details in the more details pop-up

currently, in the more info pop-up everything is center aligned, doesn't look good, as a mockup i tried playing around with the UI, can you look into the scope making the pop-up UI better

nihal467 · 2024-06-04T11:44:23Z

@skks1212

we are not able to upload a file to the consent

nihal467 · 2024-06-04T14:27:21Z

@skks1212

the page is properly responsive in multiple screen

more info page pop-up is failing responsive view

nihal467 · 2024-06-04T16:05:21Z

LGTM

skks1212 · 2024-06-06T10:27:16Z

Cypress tests failing likely due to new endpoint not present during testing

gigincg

Mentioning a few improvements that can be taken up as a separate issue

src/Components/Patient/PatientConsentRecords.tsx

gigincg · 2024-06-06T13:09:43Z

src/Components/Patient/PatientConsentRecords.tsx

  });

  const fileManager = useFileManager({
    type: "CONSENT_RECORD",
    onArchive: async () => {
      refetch();
+      refetchFiles();


Explore the possibility of Joining Applicable Files with the Consent Records on the backend

gigincg · 2024-06-06T13:15:31Z

src/Components/Patient/PatientConsentRecords.tsx

+                archiveFile={fileManager.archiveFile}
+                editFile={fileManager.editFile}
+                showArchive={showArchived}
+                files={files?.results.filter(


Explore the possibility to Associate Files to consentRecord State, rather than using a separate state for consent and files

gigincg · 2024-06-06T13:18:44Z

src/Components/Patient/PatientInfoCard.tsx

-                          Consent Records Missing
-                        </span>
+                  {!consentFilesLoading &&
+                    !consentRecordsLoading &&


Can be rendered when consentRecords Load, and the Card can be further enriched with files ones that's available in the state

src/Utils/useFileUpload.tsx

src/Components/Patient/PatientConsentRecordBlock.tsx

src/Components/Patient/PatientConsentRecords.tsx

skks1212 · 2024-06-07T05:17:11Z

@nihal467 is some testing left on this PR? It is ready to merge

nihal467 · 2024-06-07T06:42:12Z

LGTM

Dismissing to Merge

github-actions · 2024-06-07T06:49:59Z

@skks1212 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Restructured Consent Records

eb97307

skks1212 requested a review from a team as a code owner May 30, 2024 19:03

skks1212 added needs testing needs review waiting for backend labels May 30, 2024

fixed label

4662ae2

vercel bot deployed to Preview May 30, 2024 21:20 View deployment

nihal467 added test failed and removed needs testing labels May 31, 2024

made required changes

bcc31fd

vercel bot deployed to Preview June 1, 2024 15:20 View deployment

skks1212 added needs testing and removed test failed labels Jun 1, 2024

QOL updates

2e45ca9

vercel bot deployed to Preview June 1, 2024 18:05 View deployment

nihal467 added test failed and removed needs testing labels Jun 4, 2024

skks1212 requested a review from rithviknishad June 4, 2024 13:34

fix responsiveness issues

eb65b75

vercel bot deployed to Preview June 4, 2024 14:47 View deployment

skks1212 added needs testing and removed test failed labels Jun 4, 2024

vercel bot deployed to Preview June 6, 2024 08:59 View deployment

skks1212 requested review from rithviknishad and khavinshankar June 6, 2024 09:02

skks1212 removed the changes required label Jun 6, 2024

rithviknishad approved these changes Jun 6, 2024

View reviewed changes

skks1212 mentioned this pull request Jun 6, 2024

Create a new useInfiniteQuery hook to handle paginated queries independently #7985

Open

khavinshankar approved these changes Jun 6, 2024

View reviewed changes

skks1212 removed the waiting for backend label Jun 6, 2024

Merge branch 'develop' into consent-restructure

38587ca

vercel bot deployed to Preview June 6, 2024 10:57 View deployment

nihal467 added the needs testing label Jun 6, 2024

gigincg reviewed Jun 6, 2024

View reviewed changes

khavinshankar previously requested changes Jun 6, 2024

View reviewed changes

src/Components/Patient/PatientConsentRecords.tsx Show resolved Hide resolved

added consent type update option to fix migration issue

17dccab

vercel bot deployed to Preview June 6, 2024 15:31 View deployment

updates

1ca8767

vercel bot deployed to Preview June 6, 2024 17:04 View deployment

This was referenced Jun 7, 2024

flag on patient live encounter with no consent for admission #7972

Open

Improvements to Consent Records #7993

Open

nihal467 removed the needs testing label Jun 7, 2024

Merge branch 'develop' into consent-restructure

0c5dbbb

gigincg approved these changes Jun 7, 2024

View reviewed changes

vercel bot deployed to Preview June 7, 2024 06:49 View deployment

gigincg merged commit ed7b307 into develop Jun 7, 2024
23 of 27 checks passed

gigincg deleted the consent-restructure branch June 7, 2024 06:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restructured Consent Records #7946

Restructured Consent Records #7946

skks1212 commented May 30, 2024 •

edited

Loading

vercel bot commented May 30, 2024 •

edited

Loading

netlify bot commented May 30, 2024 •

edited

Loading

cypress bot commented May 30, 2024 •

edited

Loading

skks1212 commented May 31, 2024

nihal467 commented May 31, 2024 •

edited

Loading

nihal467 commented Jun 4, 2024

nihal467 commented Jun 4, 2024 •

edited

Loading

nihal467 commented Jun 4, 2024

skks1212 commented Jun 6, 2024

gigincg left a comment

gigincg Jun 6, 2024

gigincg Jun 6, 2024

gigincg Jun 6, 2024

skks1212 commented Jun 7, 2024

nihal467 commented Jun 7, 2024

github-actions bot commented Jun 7, 2024

Restructured Consent Records #7946

Restructured Consent Records #7946

Conversation

skks1212 commented May 30, 2024 • edited Loading

Proposed Changes

Merge Checklist

vercel bot commented May 30, 2024 • edited Loading

netlify bot commented May 30, 2024 • edited Loading

✅ Deploy Preview for care-egov-staging ready!

cypress bot commented May 30, 2024 • edited Loading

Passing run #2716 ↗︎

Review all test suite changes for PR #7946 ↗︎

skks1212 commented May 31, 2024

nihal467 commented May 31, 2024 • edited Loading

nihal467 commented Jun 4, 2024

nihal467 commented Jun 4, 2024 • edited Loading

nihal467 commented Jun 4, 2024

skks1212 commented Jun 6, 2024

gigincg left a comment

Choose a reason for hiding this comment

gigincg Jun 6, 2024

Choose a reason for hiding this comment

gigincg Jun 6, 2024

Choose a reason for hiding this comment

gigincg Jun 6, 2024

Choose a reason for hiding this comment

skks1212 commented Jun 7, 2024

nihal467 commented Jun 7, 2024

github-actions bot commented Jun 7, 2024

skks1212 commented May 30, 2024 •

edited

Loading

vercel bot commented May 30, 2024 •

edited

Loading

netlify bot commented May 30, 2024 •

edited

Loading

cypress bot commented May 30, 2024 •

edited

Loading

nihal467 commented May 31, 2024 •

edited

Loading

nihal467 commented Jun 4, 2024 •

edited

Loading