Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin should be able to generate a user's route map #8

Closed
agneym opened this issue Jul 14, 2020 · 6 comments
Closed

Admin should be able to generate a user's route map #8

agneym opened this issue Jul 14, 2020 · 6 comments
Assignees
Milestone

Comments

@agneym
Copy link
Contributor

agneym commented Jul 14, 2020

Admin should be able to generate a list of establishments visited by the user in case they test positive for the virus.

@agneym agneym added this to the MVP milestone Jul 14, 2020
@agneym
Copy link
Contributor Author

agneym commented Jul 14, 2020

Ref: #7 (comment)

vinay0x added a commit to vinay0x/journal that referenced this issue Jul 14, 2020
Added React rails for SSR and Webpack alias
@agneym agneym self-assigned this Jul 18, 2020
@unnitallman
Copy link
Contributor

@agneym
Copy link
Contributor Author

agneym commented Jul 19, 2020

@unnitallman We need to consolidate the two APIs required here. The current API flow dictates two steps:

  1. search for user using phone number and date of birth
  2. use the returned user ID to fetch routes.

But since phone number is unique in the first place, the search makes no sense, also with a user id that can be guessed, it's opening up the second API to search all users.
Instead we need to have a single API that can look up the user by phone number and date of birth, return user details (the name just for confirmation that admin has the right user) and route map.

@unnitallman
Copy link
Contributor

@agneym The user table uses integer ids. That is not a good thing and thats what makes it "guessable". I will change it to uuid. If so do you think, we will still need to merge the two APIs ? its not difficult to do, just let me know.

@unnitallman
Copy link
Contributor

unnitallman commented Jul 19, 2020

#65 converts ID of user table from integer to UUID. Haven't merged it yet. Once this is done, existing database will need to reset using ./bin/setup since user -> visit relationships will be affected by this change.

@agneym
Copy link
Contributor Author

agneym commented Jul 19, 2020

That sounds fine for now, we can review the UI later if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants