Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics on contributors page #162

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Add metrics on contributors page #162

merged 4 commits into from
Dec 18, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Dec 12, 2023 •
edited
Loading

Fixes #136
image

@vercel Vercel
Copy link

vercel bot commented Dec 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
leaderboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2023 11:49am

rithviknishad
rithviknishad requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Fix the eslint/prettier errors

  2. Not a fan of this UI, could we do something better? This would confuse the user on which is past weeks data and which is global data.

@rithviknishad
Copy link
Member

rithviknishad commented Dec 12, 2023 •
edited
Loading

@Pranshu1902 also rebase your changes with latest main.

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Dec 15, 2023 •
edited
Loading

Updated view @rithviknishad
image

rithviknishad
rithviknishad approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM

@rithviknishad rithviknishad merged commit 7733df0 into coronasafe:main Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show leaderboard metrics in contributor profile too
2 participants
@Pranshu1902 @rithviknishad