Filter feeds #427
Open
Filter feeds #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dgparmar14 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
|
@rithviknishad Please review this pr to close the issue. |
rithviknishad
requested changes
Apr 10, 2024
rithviknishad
requested changes
Apr 18, 2024
rithviknishad
requested changes
Apr 18, 2024
rithviknishad
requested changes
Apr 19, 2024
rithviknishad
previously approved these changes
Apr 19, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rithviknishad
requested changes
Apr 19, 2024
There was a problem hiding this comment.
-
It takes a lot of time for the page to navigate once the filter state has been changed. Let's show a loading animation.
-
The event names are not formatted to be readable.
- Let's make this an autocomplete field instead as there is a lot of repositories listed here. Also sort by last updated date.
|
@dgparmar14 any updates on this? Let's ship this out ASAP 😄 |
|
@rithviknishad Hey, I did not get ideas on how to make loading can you suggest better idea to add loading? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a need for a filter on the feed page.
This PR introduces a feature to implement filters based on repositories and events.
Fixes #424
Type of change
GithubFeed.tsxcomponent to utilizeuseStatefor applying filters.Example