corosync.conf: publicize nodelist.node.name configuration option #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was discovered that pacemaker has been occassionaly relying on those items configured in corosync.conf (and documenting so), while backpropagation got stuck somewhere. As the option is deemed generally beneficial by Honza[1], rectify this gap now and make it standard, public part of the configuration space, possibly also for other client SW to use now. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1517834#c6 Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
jnpkrn
force-pushed
the
nodelist.node.name
branch
from
23e5d7c
to
6ed71fd
Compare
|
No problem if you prefer less context attached. And thanks. |
jnpkrn
added a commit
to jnpkrn/clufter
that referenced
this pull request
Nov 30, 2017
This option within corosync configuration was silently established (and suggested to overcome certain node identification issues) by pacemaker without any awareness of the former, and hence was completely foreign also to a detached attempt to formalize this public config, interface (known as "corosync.conf" file) by the means of RelaxNG schema describing its XML equivalent and materialized as an in-tree corosync.rng file. This use to be prone to validation issues with the cib2pcscmd* commands, but since corosync now acknowledges that option just as any other native one[*], set the schema to follow suit. [*] corosync/corosync#286 Resolves: <https://bugzilla.redhat.com/1517834> Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
jnpkrn
added a commit
to jnpkrn/clufter
that referenced
this pull request
Nov 30, 2017
This option within corosync configuration was silently established (and suggested to overcome certain node identification issues) by pacemaker without any awareness within the former, and hence was completely foreign also to a detached attempt to formalize this public config, interface (known as "corosync.conf" file) by the means of RelaxNG schema describing its XML equivalent and materialized as an in-tree corosync.rng file. This use to be prone to validation issues with the cib2pcscmd* commands, but since corosync now acknowledges that option just as any other native one[*], set the schema to follow suit. [*] corosync/corosync#286 Resolves: <https://bugzilla.redhat.com/1517834> Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
jnpkrn
added a commit
to jnpkrn/clufter
that referenced
this pull request
Nov 30, 2017
This option within corosync configuration was silently established (and suggested to overcome certain node identification issues) by pacemaker without any awareness within the former, and hence was completely foreign also to a detached attempt to formalize this public config, interface (known as "corosync.conf" file) by the means of RelaxNG schema describing its XML equivalent and materialized as an in-tree corosync.rng file. This used to be prone to validation issues with the cib2pcscmd* commands, but since corosync now acknowledges that option just as any other native one[*], set the schema to follow suit. [*] corosync/corosync#286 Resolves: <https://bugzilla.redhat.com/1517834> Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
jnpkrn
added a commit
to jnpkrn/clufter
that referenced
this pull request
Dec 1, 2017
This option within corosync configuration was silently established (and suggested to overcome certain node identification issues) by pacemaker without any awareness within the former, and hence was completely foreign also to a detached attempt to formalize this public config, interface (known as "corosync.conf" file) by the means of RelaxNG schema describing its XML equivalent and materialized as an in-tree corosync.rng file. This used to be prone to validation issues with the cib2pcscmd* commands, but since corosync now acknowledges that option just as any other native one[*], set the schema to follow suit. [*] corosync/corosync#286 Resolves: <https://bugzilla.redhat.com/1517834> Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
jnpkrn
added a commit
to jnpkrn/clufter
that referenced
this pull request
Mar 14, 2018
This option within corosync configuration was silently established (and suggested to overcome certain node identification issues) by pacemaker without any awareness within the former, and hence was completely foreign also to a detached attempt to formalize this public config, interface (known as "corosync.conf" file) by the means of RelaxNG schema describing its XML equivalent and materialized as an in-tree corosync.rng file. This used to be prone to validation issues with the cib2pcscmd* commands, but since corosync now acknowledges that option just as any other native one[*], set the schema to follow suit. [*] corosync/corosync#286 Resolves: <https://bugzilla.redhat.com/1517834> Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered that pacemaker was occassionaly relying on that value
configured in corosync.conf (and documenting so), while backpropagation
got lost somewhere. As the option is deemed generally beneficial by
Honza[1], rectify this gap now and make it standard, public part of
the configuration space, possibly also for other client SW to use now.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1517834#c6
Signed-off-by: Jan Pokorný jpokorny@redhat.com