Blackbox disable #308
Closed
Blackbox disable #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfriesse
force-pushed
the
blackbox-disable
branch
from
d6b7aa8
to
aca16fa
Compare
Signed-off-by: Jan Friesse <jfriesse@redhat.com>
Signed-off-by: Jan Friesse <jfriesse@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch is for sure something we would like to have (at least in my opinion :) )
Second patch is more like a speculative and I believe the problem should be solved by libqb (not overwriting existing file/unlink after mmap) and not workarounded by corosync.
Both patches are applicable to both master and needle.