Fix no link0 startup #484
Closed
Fix no link0 startup #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As totem_config->interfaces entries are _all_ possible links and not only the configured ones we cannot trust that interface[0] is configured at the time of checking, and thus has a valid member_count. So set the members variable to the member_count entry from an actually configured interface and loop over that one. This fixes a case where the check for the name property on all nodes for multi links was skipped if link 0 was not configured, as then its member_count was 0. Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
configured links may not come in order in the interfaces array, which holds an entry for _all_ possible links, not just configured ones. So iterate through all interfaces, but skip those which are not configured. This allows to start corosync with a configuration where link 0 is currently not mentioned, as else it was checked but had member_count = 0 from it's default initialization, which then made this code report a false positive for the "Not all nodes have the same number of links" check even on a correct config. Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
Can one of the admins verify this patch? |
|
@knet-ci-bot ok to test |
|
Looks fine so ACK by me, but I would like also ask @chrissie-c for her opinion, because she has more experience in this part of code. |
chrissie-c
approved these changes
Jun 17, 2019
|
@chrissie-c Thank you for additional ack. @GamerSource Thank you for the patch (and braveness for making totemconfig a bit better) . I've merged patches as a 7ada508 and 816324c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.