New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
totemconfig: Add support for knet_mtu #708
Conversation
bdc4045
to
f760a8b
Compare
I've changed totemknet reload notify code to be (hopefully) a bit more understandable + improved documentation of net_mtu (hopefully). @chrissie-c Code was already ACKed by Fabio but I would be really grateful if you could review it too and specially review my "english" and potentially convert it to English. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine to me, some fixes to the English :)
option. | ||
|
||
For UDPU (and UDP) to set this value beyond 1500, the regular frame MTU, | ||
requires ethernet devices that support large, or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This specifies maximum packet length sent by corosync. It's mainly for the UDPU
(and UDP) transport, where it specifies the network maximum transmit size, but
can be used also with the KNET transport, where it defines the maximum length of packets
passed to the knet layer. To specify the network MTU manually for KNET, use the
.B knet_mtu
option.
For UDPU (and UDP), setting this value beyond 1500, the regular frame MTU,
requires ethernet devices that support large, or"
@@ -293,7 +300,7 @@ that some device in the network doesn't support large frames. | |||
|
|||
Choose hardware carefully if intending to use large frame support. | |||
|
|||
The default is 1500. | |||
The default is 1500 for UDPU (and UDP) and 65536 for KNET transport. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default is 1500 for UDPU (and UDP) and 65536 for the KNET transport.
the lowest MTU between the selected intefaces. | ||
|
||
The default value is 0. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch between manual and automatic MTU discovery. A value of 0 means
automatic, other values set a manual MTU.
In a setup with multiple interfaces, please specify
the lowest MTU of the selected interfaces.
The default value is 0.
totem.knet_mtu is new configuration option which allows setting of automatic or manual knet MTU. Also reload of totem.knet_pmtud_interval is fixed now, so it works when key is deleted (and set back default value). Signed-off-by: Jan Friesse <jfriesse@redhat.com>
f760a8b
to
39162ab
Compare
@chrissie-c Thank you for English fixes. Force-pushed now, will wait for CI and merge then. |
Merged as 91348f8 |
totem.knet_mtu is new configuration option which allows setting of automatic or manual knet MTU.
Also reload of totem.knet_pmtud_interval is fixed now, so it works when key is deleted (and set back default value).
Signed-off-by: Jan Friesse jfriesse@redhat.com