2fa - allow populating the login data structure via callback for 2fa #18
Conversation
|
As I see this allows API auth as well - maybe it's better to have this as general auth_cb which gets the login data passed for easy manipulation? def authenticate(data: Dict[str, str]):
…
return data
client = Client(server, email, password, auth_cb=authenticate) |
|
Thanks for the contribution ! I am not sure to understand well what you mean. If it's a spelling suggestion, yes i would argue that Would you mind then updating this PR as i'm more than willing to merge it ! |
allows other login mechanisms such as totp or api key.
example:
def mfa2fa(loginpayload):
totp = pyotp.TOTP(otpseed)
loginpayload.update(
{
"twoFactorToken": str(totp.now()),
"twoFactorProvider": "0",
"twoFactorRemember": "0"
}
)
return loginpayload
client = Client(server, email, password, authentication_cb=mfa2fa)
def api_key(loginpayload):
loginpayload.update(
{
"client_id": CLIENT_ID,
"client_secret": CLIENT_SECRET,
"scope": "api",
"grant_type": "client_credentials"
}
)
return loginpayload
client = Client(server, email, password, authentication_cb=api_key)
|
Had some spare characters, made it authentication_cb. |
|
I was going to do it myself after merge, but you can of course do it yourself by adding an exemple to https://github.com/corpusops/bitwardentools/blob/main/USAGE.md (like copy/pasting/adapting what you already posted in commit message) And also add changelog entry in https://github.com/corpusops/bitwardentools/blob/main/CHANGES.md So i'm waiting for it, or tell me to do it myself ! |
|
just go ahead - you know how it is meant to look like feel free to https://gist.github.com/wtbarnes/56b942641d314522094d312bbaf33a81 |
This allows supplying 2fa tokens to the login.
e.g. using pyotp