Relax VerifyCACerts expiry condition #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, avoid noise from this test failing a lot, without any action required to resolve it on our end. As described in the comment, the current condition (at least 90 days before expiry, otherwise fail), is unhelpfully strict. It makes sense for upstream OpenJDK, since they use this as an early warning to take an action, but we rely on OpenJDK and Amazon Linux to manage the certificates for us so we do not take action when this condition fails, at the moment. So, relax the condition a little to wait for the cert to be 90 days *past* expiry before failing, at which point something has definitely gone wrong and we want to investigate.
lutkerd
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport corretto/corretto-jdk@13cbe35
Relax VerifyCACerts expiry condition