Move version numbers to variables #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziyiluo
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches hard coded version numbers to variables. This allows for easier portability of code and transitions to new versions.
Related issues
This will help prevent issues like #10
Motivation and context
This should help with releasing new versions of Corretto as they become available to ensure consistency of version numbers across the macOS packages.
How has this been tested?
Local builds and installs on macOS Mojave 10.14.6 (18G2022)
Platform information
Specifically targeting macOS.
Additional context
If accepted, I will work on porting over to Corretto 8 as well.