Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport JDK-8186090: java.nio.Bits.unaligned() doesn't handle aarch64 #250

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

alvdavi
Copy link
Contributor

@alvdavi alvdavi commented Jul 6, 2020

Description

This fixes an issue that happened during the import of the aarch64 port from Icedtea due to different implementation of JDK-8158260:

IcedTea: http://icedtea.classpath.org/hg/icedtea8-forest/jdk/rev/bc6eab2038c6
JDK: http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/6021c95f5944

This led to IcedTea skipping 8186090, but Corretto, which uses the JDK implementation for 8158260, needs it.

Related issues

java.nio.Bits.unaligned() doesn't handle aarch64
https://bugs.openjdk.java.net/browse/JDK-8186090

PPC64: unaligned Unsafe.getInt can lead to the generation of illegal instructions
https://bugs.openjdk.java.net/browse/JDK-8158260

@alvdavi
Copy link
Contributor Author

alvdavi commented Jul 6, 2020

This should fix #248

Copy link
Contributor

@cliveverghese cliveverghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvdavi alvdavi merged commit cd4e3ba into corretto:develop Jul 7, 2020
@alvdavi alvdavi deleted the 8186090 branch July 7, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants