Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate cacerts and newly added AL certs #457

Merged
merged 2 commits into from Apr 12, 2023
Merged

Remove duplicate cacerts and newly added AL certs #457

merged 2 commits into from Apr 12, 2023

Conversation

Rudometov
Copy link
Contributor

Backport from corretto-17

Removed duplicate cacerts from amazon-cacerts file to reduce the overall size of resulting cacerts. Removed new AL certs to reduce the size. Updated VerifyCACerts test accordingly.

~/workspace/jtreg4/bin/jtreg -jdk:amazon-corretto-8.382.00.1-linux-x64/ jdk/test/sun/security/lib/cacerts/VerifyCACerts.java
Test results: passed: 1

~/workspace/jtreg4/bin/jtreg -jdk:amazon-corretto-8.382.00.1-linux-x64/ jdk/test/sun/security/ssl/X509TrustManagerImpl/CacertsLimit.java
Test results: passed: 1

keytool -list -v -keystore amazon-corretto-8.382.00.1-linux-x64/jre/lib/security/cacerts -storepass "changeit" | grep -E "Alias name:" | wc -l
144

Copy link
Contributor

@navyxliu navyxliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 95k saved.

@Rudometov Rudometov merged commit 6657c50 into corretto:develop Apr 12, 2023
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants