Add github action to generate tags and diff #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutkerd
reviewed
Nov 22, 2021
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| script: | | ||
| commentText = 'Diff for ' + context.payload.pull_request.head.sha + ':\n\n' | ||
| needNewComment = true; |
There was a problem hiding this comment.
Can you add some comments on what this is doing in the different blocks?
There was a problem hiding this comment.
Added. Some of the descriptions are available in console.log's as well.
lutkerd
reviewed
Nov 22, 2021
| @@ -0,0 +1,41 @@ | |||
| import json | |||
|
|
|||
| DEFAULT_ALPINE_VERSION = '3.12' | |||
There was a problem hiding this comment.
We should update to a newer base version since 3.12 goes out of support relatively soon.
There was a problem hiding this comment.
Yes, I will be creating a PR once this is merged to address this.
bin/tag-generator.py
Outdated
| print("Architectures: amd64, arm64v8") | ||
| print(f"Directory: {key}/jdk/al2\n") | ||
|
|
||
| for alpine_version in ['3.12', '3.13', '3.14']: |
There was a problem hiding this comment.
Can we pull this list up to a top level var?
| @@ -10,16 +12,15 @@ update_musl_linux() { | |||
| CORRETTO_VERSION=$1 | |||
| MAJOR_RELEASE=$2 | |||
|
|
|||
| sed -i "" "s/ARG version=.*/ARG version=${CORRETTO_VERSION}/g" ./${MAJOR_RELEASE}/jdk/alpine/Dockerfile | |||
| ${SED} "s/ARG version=.*/ARG version=${CORRETTO_VERSION}/g" ./${MAJOR_RELEASE}/jdk/alpine/Dockerfile | |||
There was a problem hiding this comment.
I think we should create a backlog item to change this to use templates and not a ton of sed commands.
There was a problem hiding this comment.
Created Issue #81 for this.
lutkerd
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add Github actions to generate tags for docker library and validate that the content of the repository is the expected content.
Sample of the content available at PR : cliveverghese#6