Add Maven project support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
reviewed
Dec 14, 2021
|
Hey @yishaigalatzer, since the project has been converted to a Gradle project, this PR is no longer necessary since the publish to Maven can be achieved using the Gradle project. |
|
Okay, discussing further with @yishaigalatzer looks like we do want a Maven version of this project as well for distributing outside of Maven central. |
dagnir
force-pushed
the
maven-project
branch
from
9dab83b
to
0aa694b
Compare
|
Updated the project to mirror the current gradle build file |
dagnir
force-pushed
the
maven-project
branch
from
0aa694b
to
5fb1998
Compare
zoewangg
approved these changes
Dec 15, 2021
|
This PR is trying to undo #27, probably unintended |
Rollback was to support older versions of ASM. Discussed offline, will update this once the ASM lib is included directly in the project. |
lutkerd
reviewed
Dec 16, 2021
dagnir
force-pushed
the
maven-project
branch
from
19926c3
to
a13c4ed
Compare
dagnir
force-pushed
the
maven-project
branch
from
a13c4ed
to
b10334d
Compare
alvdavi
approved these changes
Dec 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This change allows this project to be built using Maven. Project build/config based on the
build.gradlefile.Tested using
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.