Fix usage of corrosion via add_subdirectory by promoting variables to CACHE #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the variables that corrosion provides for its users like
Rust_VERSION<_MAJOR|_MINOR|_PATCH>
are only available when corrosion is installed and importedvia
find_package(Corrosion)
. This is because these variables are set as normal variables withCMakes set() command, which limits their scope. When corrosion is imported via
add_subdirectory
,these variables were only visible to corrosion, but not to the caller of
add_subdirectory
, whichis fixed by this commit.